Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612979 Matthias Clasen <mclasen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #2 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-07-09 09:58:45 EDT --- package name: ok, considering this is a special case for parallel installability spec file name: ok packaging guidelines: ok, but if the package is only destined for f13+, some cleanups are possible: - drop BuildRoot - drop initial rm -rf in %install - drop %clean license: ok license field: ok license file: ok spec file language: ok spec file readability: ok upstream sources: ok builable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok dir ownership: ok duplicate files: ok; COPYING and README not strictly required in -devel, but ok file permissions: ok macro use: ok content: permissible large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok Please fix the typo in %description. Approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review