Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531544 --- Comment #7 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-07-09 02:13:08 EDT --- (In reply to comment #6) > > - The name is incorrect. This is a tool, not a pure python library, so the name > > should be just trml2pdf. > My initial name was trml2pdf, but another Fedora packager suggested me > something else: > <abadger1999> ciupicri: Since it's a dependency, is it the python module or > the program that's being used? > <ciupicri> abadger1999, the python module > <ciupicri> abadger1999, satchmo (django app) uses its library not its program > <abadger1999> ciupicri: Ideally, upstream would split the script out into its > own file and import the module to make the script run but it sounds like > upstream is pretty dead. > <abadger1999> So I'd do this: > <abadger1999> link the trml2pdf.py file to %{_bindir}/trml2pdf (leave off > the .py extension in bindir) > <abadger1999> and name the package python-trml2pdf Hmm, OK, in that case the name python-trml2pdf is probably OK. > > - URL is incorrect, it should be something of the sort > > http://packages.pardus.org.tr/contrib/source/trml2pdf.html > > (it should point to the package homepage, not the directory where the tarball > > has been taken from) > As far as I know the package is unmaintained, so that why I've used that URL. How do you know that it's unmaintained? You can always ask upstream... > > Please use more explicit statements such as > > %{python_sitelib}/trml2pdf/ > > %{python_sitelib}/trml2pdf-*.egg-info > It's nice to have a more explicit list of the included files, but on the other > hand I think that it makes things a bit harder to maintain. I've also seen a > counter example: > http://cvs.fedoraproject.org/viewvc/rpms/python-fedora/F-13/python-fedora.spec?view=markup > . Well, that's really just a sad excuse :) And maintaining is not complicated at all, you just have to write a few more characters initially.. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review