Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225780 Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |gholms@xxxxxxxxxxxxxxxxx Resolution| |RAWHIDE AssignedTo|nobody@xxxxxxxxxxxxxxxxx |gholms@xxxxxxxxxxxxxxxxx --- Comment #2 from Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> 2010-07-09 00:25:08 EDT --- Everything checks out as far as I can tell. While it isn't mandatory, you might want to query upstream about including the text of the GFDL in their source tarball (COPYING-DOCS) so it can go in the package. Consider also using %global over %define. A full review is attached. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review