Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225759 Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gholms@xxxxxxxxxxxxxxxxx --- Comment #7 from Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> 2010-07-08 23:39:42 EDT --- I, for one, agree with the above (ancient) commentary: as long as you justify not using noreplace you should be fine. All you have to do is briefly note it in the spec file. There isn't a whole lot to do for this package; most everything is a simple one-line tweak. If you need someone else to make a patch to fix these issues for some reason I can do so. A full review for this package is attached. Below are just the parts that need fixing. (Hopefully bugzilla won't mangle my spacing.) Mandatory review guidelines: NO - rpmlint output prereq is deprecated: Change PreReq to Requires make-check-outside-check-section: Just put make check in a %check section conffile-without-noreplace-flag: Justified in this bug; should also note in spec NO - Package's files and directories don't conflict with others' Both fontconfig and fontpackages-filesystem own /usr/share/fonts Packaging guidelines: NO - Spec file lacks Packager, Vendor, PreReq tags Please change PreReq to Requires. NO - %build honors applicable compiler flags or justifies otherwise Building with make %{?_smp_mflags} seems to work for me; if it actually doesn't please mention so in the spec file. NO - %config files marked noreplace or justified Justified in this bug; should also note in spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review