Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531544 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-07-08 18:28:55 EDT --- First of all, as a sponsor I think you need to do more informal reviews. I see you have been already active otherwise, but that does not make up for review experience. Reviewing is a very important part of being involved in Fedora packaging, and there is no better way to show that you understand the guidelines. As a reminder the most important ones are http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines Additionally to the Packaging Guidelines, there are a bunch of language / application specific guidelines that are linked to in the Packaging Guidelines. Here are some tricks of the trade: http://fedoraproject.org/wiki/Packaging_tricks http://fedoraproject.org/wiki/Packaging/ScriptletSnippets http://fedoraproject.org/wiki/Common_Rpmlint_issues Some comments about the package itself: - The name is incorrect. This is a tool, not a pure python library, so the name should be just trml2pdf. - The summary and description conflict. Besides, the description being shorter than the summary is quite nonorthodox. I'd change them both to something like "A tool to convert Report Markup Language (RML) files to PDF" - URL is incorrect, it should be something of the sort http://packages.pardus.org.tr/contrib/source/trml2pdf.html (it should point to the package homepage, not the directory where the tarball has been taken from) - You don't need to use "%{__python}", plain "python" will do just fine. - Don't use wildcards where they are not necessary: from the statement %{python_sitelib}/* it is not clear what actually gets included. In the case of Python this has also practical implications - normally, in addition to the library also an egg is produced. Using the wildcard prevents you from being notified that the egg is missing. Please use more explicit statements such as %{python_sitelib}/trml2pdf/ %{python_sitelib}/trml2pdf-*.egg-info -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review