Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557011 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #8 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-07-07 14:46:47 EDT --- Other things: * Requires - Some "Requires(postun)" is needed (postun calls /sbin/service) * Macros / symlink -------------------------------------------------------------- ln -s ../..%{_sbindir}/clamd $RPM_BUILD_ROOT/usr/sbin/clamd.clamsmtp -------------------------------------------------------------- - Note that %{_sbindir} = /usr/bin, i.e. clamd binary and clamd.clamsmtp symlink (to be created) are in the same directory. So the following is enough. -------------------------------------------------------------- ln -sf clamd $RPM_BUILD_ROOT%{_sbindir}/clamd.clamsmtp -------------------------------------------------------------- Also please use macros for "basic" directories. - Use macros consistently. For example: -------------------------------------------------------------- 57 mkdir -p $RPM_BUILD_ROOT%{_var}/lib/clamsmtp 85 getent passwd clamsmtp >/dev/null || useradd -r -g mail -d /var/lib/clamsmtp -s ...... 105 %attr(755,clamsmtp,mail) %{_var}/lib/clamsmtp -------------------------------------------------------------- By the way please begin release number with "1", and increment it every time you modify your spec file (when version does not change) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review