Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226443 --- Comment #9 from Ngo Than <than@xxxxxxxxxx> 2010-07-07 11:53:21 EDT --- (In reply to comment #8) > MUST: > - Desktop-file-validate must be run in %install, not in %check. See > http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage > it's fixed in switchdesk-4.0.9-8.fc14 > - The source URL works now, but is this a long-term solution? The sources > should be moved to fedorahosted.org. > no, it will be moved to fedorahosted.org > SHOULD: > - I usually like a bit more verbosity in %files; statements such as > %{_bindir}/* > and > %{_mandir}/man1/* > can be a bit dangerous. You can easily fix this by changing them into > %{_bindir}/%{name}* > and > %{_mandir}/man1/%{name}* > > > The remaining issues are cosmetic. Please fix at least the MUST items before a > cvs push. This package has been > > APPROVED fixed in 4.0.9-8.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review