Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226443 --- Comment #7 from Ngo Than <than@xxxxxxxxxx> 2010-07-07 10:15:58 EDT --- (In reply to comment #6) > rpmlint output: > switchdesk.noarch: W: no-manual-page-for-binary switchdesk-helper this binany is backend and the user should not launch it. no manual page is needed. It's OK > switchdesk-gui.noarch: W: no-documentation there's no documentation atm, but i don't think it's a blocker for this review > 3 packages and 0 specfiles checked; 0 errors, 2 warnings. > > - Consider adding INSTALL="install -p" to make install, to preserve time > stamps. > > - Source URL is incorrect. > > - There is python stuff installed, so I think you should BuildRequires: > python-devel. > > > Full review as follows: > > MUST: The spec file for the package is legible and macros are used > consistently. OK > MUST: The package must be named according to the Package Naming Guidelines. OK > MUST: The spec file name must match the base package %{name}. OK > MUST: The package must be licensed with a Fedora approved license and meet the > Licensing Guidelines. OK > MUST: The License field in the package spec file must match the actual license. > OK > > MUST: The sources used to build the package must match the upstream source, as > provided in the spec URL. NEEDSWORK > > MUST: The package MUST successfully compile and build into binary rpms. OK > MUST: The spec file MUST handle locales properly. OK > MUST: Optflags are used and time stamps preserved. ~OK > MUST: Packages containing shared library files must call ldconfig. N/A > > MUST: A package must own all directories that it creates or require the package > that owns the directory. ~OK > - You're using "switchdesk" in the main %files, but "%{name}" in -gui. This is > a bit illogical, please consider unifying the use. > > MUST: Files only listed once in %files listings. OK > MUST: Debuginfo package is complete. N/A > MUST: Permissions on files must be set properly. OK > MUST: Clean section exists. OK > MUST: Large documentation files must go in a -doc subpackage. N/A > > MUST: All relevant items are included in %doc. Items in %doc do not affect > runtime of application. OK > - Maybe add ChangeLog? > > MUST: Header files must be in a -devel package. N/A > MUST: Static libraries must be in a -static package. N/A > MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A > MUST: If a package contains library files with a suffix then library files > ending in .so must go in a -devel package. N/A > MUST: In the vast majority of cases, devel packages must require the base > package using a fully versioned dependency. N/A > MUST: Packages does not contain any .la libtool archives. N/A > > MUST: Desktop files are installed properly. NEEDSWORK > - Must run e.g. > desktop-file-validate %{buildroot}/%{_datadir}/applications/foo.desktop > > MUST: No file conflicts with other packages and no general names. OK > MUST: Buildroot cleaned before install. OK > SHOULD: %{?dist} tag is used in release. OK > SHOULD: If the package does not include license text(s) as separate files from > upstream, the packager should query upstream to include it. OK > SHOULD: The package builds in mock. OK fixed in switchdesk-4.0.9-7.fc13, you can download it from http://than.fedorapeople.org/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review