Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213832 ------- Additional Comments From tmraz@xxxxxxxxxx 2006-11-09 04:39 EST ------- > * The service related scriptlets don't follow the guidelines What do you mean? > * the adduser followed by a chsh is a bit odd. This was probably some preventive action for the case when the user was already there. I'd leave it on packager to decide if chsh should be removed or not. > * in %files /etc should certainly be %{sysconfdir} I've overlooked that. Miroslav, please correct that. > * if there is a libpcap library nearby (see line 209 to 221 in configure.ac) it is used, for example in the BUILD directory. Maybe this part of the configure/configure.ac could be patched out. It shouldn't be annoying in mock, however. I've noticed that too, I don't think it must be fixed but it would be good idea. > * some Requires are missing. I think /usr/sbin/sendmail or smtpdaemon > (and also maybe /usr/sbin/sendmail as BuildRequires). snmpwalk is > more or less required for arpsnmp, but it is better in my opinion not > to have a dependency nor do something special, the sysadm should be able > to figure out. I agree that sendmail probably should be required. smtpdaemon not as it is definitely optional thing and arpwatch is usable without it. I don't think that the package should require snmpwalk. This is unnecessary bloat in case someone wants to use just arpwatch. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review