Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608326 --- Comment #7 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-07-06 22:20:01 EDT --- I should have added that the *'s in my review were more important, i.e. blockers. !'s were suggestions and warnings. But almost everything is straightened out now as it seems, except the package name. I understand the convention you're using. However according to the guidelines, the latest stable version should be a straight "gtkmm", and older (or unstable newer) can have versions appended to the name, like automake14, python3 etc. I also understand that there is not enough manpower to change package names and do reviews, on every API change. Since this is the way it has been with gtk packages, I guess nobody will yell. Fair enough. There is one last issue though. I think you didn't run rpmlint against the newest build. The devel package itself gives 25 errors, 48 warnings, such as W: doc-file-dependency W: spurious-executable-perm E: arch-dependent-file-in-usr-share etc. You might want to have a look. I am not pasting the output here, as it is really long. > That leaves us with only: > %doc demos/gtk-demo/ > in -devel package. I wonder if it'd be better to move gtk-demo to -doc package > too, so that most docs (including NEWS and ChangeLog) are in main package, > -devel package contains no docs, and API docs + demos are in -doc package? I am fine either way. But make sure you don't build them if you are putting them in /usr/share/, c.f. the rpmlints above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review