Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pungi - Distribution compose tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214730 ------- Additional Comments From pertusus@xxxxxxx 2006-11-09 04:19 EST ------- * name right * follow packaging guidelines * match uptream 6fab9b1b9979aa59b9db5880abfe6136 pungi-0.1.0.tar.gz * sane provides: Provides: config(pungi) = 0.1.0-1 * specfile simple and legible * %files section right * rpmlint says: E: pungi non-executable-script /usr/lib/python2.4/site-packages/pypungi/pungi.py 0644 E: pungi non-executable-script /usr/lib/python2.4/site-packages/pypungi/splittree.py 0644 E: pungi non-executable-script /usr/lib/python2.4/site-packages/pypungi/gather.py 0644 This is ignorable, as you explained above. However wouldn't it make sense to have wrapper around those scripts, named for example pungi-gather or the like, wouldn't it make sense to call them independently? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review