Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226111 --- Comment #23 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2010-07-05 13:04:40 EDT --- Currently reviewing lvm2-2.02.69-1.fc14.src.rpm. rpmlint output now stands at cmirror.x86_64: E: non-standard-executable-perm /etc/rc.d/init.d/cmirrord 0555L cmirror.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/cmirrord cmirror.x86_64: W: no-reload-entry /etc/rc.d/init.d/cmirrord device-mapper.x86_64: E: explicit-lib-dependency libudev device-mapper.x86_64: W: spelling-error %description -l en_US userspace -> user space, user-space, users pace device-mapper-devel.x86_64: W: no-documentation device-mapper-event.x86_64: E: non-standard-executable-perm /sbin/dmeventd 0555L device-mapper-event-devel.x86_64: W: no-documentation device-mapper-event-libs.x86_64: W: spelling-error %description -l en_US libdevmapper -> clapperboard, understrapper, backslapper device-mapper-event-libs.x86_64: W: no-documentation device-mapper-libs.x86_64: W: spelling-error %description -l en_US libdevmapper -> clapperboard, understrapper, backslapper device-mapper-libs.x86_64: W: no-documentation lvm2.src: W: spelling-error Summary(en_US) Userland -> User land, User-land, Sunderland lvm2.src: W: spelling-error %description -l en_US mdadd -> daddy, Madden, Maddox lvm2.src: W: spelling-error %description -l en_US losetup -> lo setup, lo-setup, loser lvm2.src: W: no-cleaning-of-buildroot %install lvm2.src: W: no-buildroot-tag lvm2.x86_64: W: spelling-error Summary(en_US) Userland -> User land, User-land, Sunderland lvm2.x86_64: W: spelling-error %description -l en_US mdadd -> daddy, Madden, Maddox lvm2.x86_64: W: spelling-error %description -l en_US losetup -> lo setup, lo-setup, loser lvm2.x86_64: E: non-standard-executable-perm /sbin/lvmconf 0555L lvm2.x86_64: E: non-standard-executable-perm /sbin/lvm 0555L lvm2.x86_64: E: non-standard-dir-perm /var/lock/lvm 0700L lvm2.x86_64: E: non-standard-executable-perm /etc/rc.d/init.d/lvm2-monitor 0555L lvm2.x86_64: E: non-standard-executable-perm /sbin/lvmdump 0555L lvm2.x86_64: E: non-standard-executable-perm /sbin/vgimportclone 0555L lvm2.x86_64: E: non-standard-executable-perm /sbin/fsadm 0555L lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/backup 0700L lvm2.x86_64: E: non-standard-dir-perm /etc/lvm 0700L lvm2.x86_64: W: hidden-file-or-dir /etc/lvm/cache/.cache lvm2.x86_64: E: non-readable /etc/lvm/cache/.cache 0600L lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/archive 0700L lvm2.x86_64: E: non-standard-dir-perm /etc/lvm/cache 0700L lvm2.x86_64: W: service-default-enabled /etc/rc.d/init.d/lvm2-monitor lvm2.x86_64: W: service-default-enabled /etc/rc.d/init.d/lvm2-monitor lvm2.x86_64: W: no-reload-entry /etc/rc.d/init.d/lvm2-monitor lvm2.x86_64: W: incoherent-init-script-name lvm2-monitor ('lvm2', 'lvm2d') lvm2-cluster.x86_64: W: spelling-error Summary(en_US) userland -> user land, user-land, Sunderland lvm2-cluster.x86_64: E: non-standard-executable-perm /etc/rc.d/init.d/clvmd 0555L lvm2-cluster.x86_64: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/clvmd lvm2-cluster.x86_64: W: incoherent-init-script-name clvmd ('lvm2-cluster', 'lvm2-clusterd') lvm2-devel.x86_64: W: no-documentation lvm2-libs.x86_64: W: no-documentation lvm2-libs.x86_64: E: non-standard-executable-perm /lib64/device-mapper/libdevmapper-event-lvm2snapshot.so 0555L lvm2-libs.x86_64: E: non-standard-executable-perm /lib64/device-mapper/libdevmapper-event-lvm2mirror.so 0555L 13 packages and 0 specfiles checked; 18 errors, 27 warnings. - The explicit libudev require is OK. - The no-buildroot and no-cleaning-of-buildroot warnings are OK, since this version is in rawhide where RPM handles this stuff automatically. (Wouldn't hurt having them, though.) - Although normally services aren't usually enabled by default, I'm sure LVM as a core package is a sane exception to the rule. What I think should still be fixed: - The perms are usually 755 for libraries and executables. Please fix the install commands in the Makefile, or run chmod in %install. - Add the reload entries and the Default-Stop lines to the init scripts. https://fedoraproject.org/wiki/Packaging/SysVInitScript#Required_Actions https://fedoraproject.org/wiki/Packaging/SysVInitScript#.23_Default-Stop:_line Otherwise all of the issues of comment #2 have been addressed. PS. Shouldn't the URL be http://sourceware.org/lvm2/ ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review