Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607778 Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #6 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-07-04 17:51:30 EDT --- New Package CVS Request ======================= Package Name: xnoise-plugins-core Short Description: Core plugins for xnoise Owners: salimma Branches: F-12 F-13 InitialCC: (In reply to comment #5) > JFTR, the review guidelines say: > > | SHOULD: The reviewer should test that the package functions as > | described. A package should not segfault instead of running, for example. > Apologies there. The plugins were in working order at some point before 0.1.6 came out, but I still should have not assumed that's still the case with the released versions. I guess xnoise is still in flux and the plugins lag a bit behind xnoise itself. > We could go on with even more disabled plugins. Eventually, no plugin may be > left. ;) Or old/new segfaults might return with one of the next updates after > package approval. > > Whether 0.1.6 is ready for Rawhide, I leave this decision to you. It's ready for Rawhide, I guess, but I'd probably keep it there and not push it to F-12 and F-13 until they are more stable. > > [...] > > About the .pc file: Consider merging this dubious -devel subpackage into the > xnoise-plugins-core package. Possibly with a virtual -devel pkg or only when > you learn about something that would need such a BuildRequires. Rationale: Good idea; will delete it for now -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review