Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607802 --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-07-04 13:50:50 EDT --- Created an attachment (id=429393) --> (https://bugzilla.redhat.com/attachment.cgi?id=429393) screenshot when Agender crashes with segv Some notes: * SourceURL: - For tarball hosted on sourceforge.net, please use: https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net * Explicit version dependency - wxGTK on supported branches of Fedora have version higher than 2.8.0 and explicit version dependency ">= 2.8.0" is not needed: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * %setup - By default %setup must be quiet (i.e. please use %setup -q) * indentation - Please remove unneeded spaces before each line. * %configure --prefix=%{_prefix} is not needed ( You can check what %configure actually does by $ rpm --eval %configure ) * cleaning $RPM_BUILD_ROOT - Please remove unneeded "test -n "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != "/" &&" hack ! Note that on F-12 and above, $RPM_BUILD_ROOT is always cleaned up before %install section begins, so even "%{__rm} -rf $RPM_BUILD_ROOT" is not needed on %install ! Also on F-13 and above writing %clean section explicitly is not needed. * Timestamps - Please consider to use --------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" --------------------------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated by recent autotools. * Consistent macros usage - Please unify %{__make} and %__make . * Desktop file - If desktop file is installed, desktop-file-{install,validate} must be used to verify the installed file. https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files * %changelog - Please write proper %changelog entry: https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs By the way, when I - launch two terminals (like uxterm) - In one terminal, type $ Agender - After that in another terminal type $ Agender then Agender launched on the first terminal causes segv. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review