Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605373 --- Comment #16 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> 2010-07-04 01:04:19 EDT --- It's better to use QString() for the default arguments rather than (const char *) 0 (the default constructor is faster and does the same thing; if you write (const char *) 0 as a default argument, that implicitly calls the QString(const char *) constructor). Volker has been working on a newer specfile, we've been talking to each other on IRC, but I'm waiting for him to upload it. We had the qt4-webkit-devel BR already figured out (it should use the qt4-webkit-devel virtual Provides, which is also provided by qt-devel on Fedora < 14) and he was struggling with the QString(0) issues, so maybe your patch will help. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review