[Bug 607778] Review Request: xnoise-plugins-core - Core plugins for xnoise

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607778

--- Comment #4 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-07-03 09:52:57 EDT ---
(In reply to comment #3)

Updated SRPM:
http://salimma.fedorapeople.org/specs/gnome/xnoise-plugins-core-0.1.6-2.fc13.src.rpm

> * "BuildRequires: intltool" is missing
Fixed
> 
> 
> * MediaWatcher plugin crashes:
>   1) start xnoise
>   2) open Preferences > Plugins
>   3) enable MediaWatcher
>   4) disable MediaWatcher
>   5) enable MediaWatcher
>   6) GLib-GObject warnings on stderr + segfault
Confirmed; reporting upstream and disabling for now
> 
> 
> * LastfmCovers plugin crashes on exit:
>   1) start xnoise
>   2) enable LastfmCovers plugin
>   3) quit
>   4) segfault
Confirmed. Looks like something broke between the last development version I
tried before 0.1.6 (0.1.2 or so), and I did not notice because my albums
already have their cover images cached

Disabling for now -- is this the error you get?
Failed to open file
'/home/michel/.config/xnoise/album_images/kate_walsh/tim's_house/tim's_house_medium':
No such file or directory
Failed to open file
'/home/michel/.config/xnoise/album_images/kate_walsh/tim's_house/tim's_house_medium':
No such file or directory
*** glibc detected *** xnoise: malloc(): smallbin double linked list corrupted:
0x0000000001006cf0 ***


> * Notifications plugin prints "<b> ... </b>"
Fixed; patch sent upstream

> * /usr/lib64/xnoise/*.la files are not needed
Done
> 
> 
> * xnoise-plugins-core.x86_64: E: incorrect-locale-subdir
> /usr/share/locale/default/LC_MESSAGES/xnoise-plugins-core.mo
> 
> 
> * %{_libdir}/xnoise ownership : currently owned by the -plugins-core package,
> which is optional, however. Would separate xnoise plugin packages need to own
> %{_libdir}/xnoise  or do you think it would be better to make the base "xnoise"
> package own that directory?
That is true. I'll make xnoise owns it, but since xnoise is already in the
override tag, the switch could probably happen after the initial
xnoise/xnoise-plugins-core combo is released.

> * xnoise-plugins-core-devel : What's the purpose of this package? The current
> %description can't be correct. ;-)
Actually .. I'm not sure. the .pc file does not actually specify where plugins
should be installed, but it does at least specify how to find the xnoise
package. I have adjust the description.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]