Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604227 Bruce Cowan <bugs@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs@xxxxxxxxxxxx --- Comment #1 from Bruce Cowan <bugs@xxxxxxxxxxxx> 2010-07-03 08:59:16 EDT --- Here's an informal review: The spec's layout is rather messy, it should conform to the template. https://fedoraproject.org/wiki/Packaging/Guidelines#Writing_a_package_from_scratch The Release should contain %{dist} https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Using_the_.25.7B.3Fdist.7D_Tag The BuildRoot tag is no longer required https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag rm -rf $RPM_BUILD_ROOT is not required in %install any more https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag %clean is no longer required https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean There is no changelog https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review