Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608470 --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-07-03 03:07:18 EDT --- Quick notes (not yet a review) Release must be fixed 1%{?dist} (set %dist .fc13 in your .rpmmacros) $ rpmlint -v perl-Test-Script-Run.spec /home/extras/SRPMS/perl-Test-Script-Run-0.04-1.fc8.src.rpm /home/extras/RPMS/noarch/perl-Test-Script-Run-0.04-1.fc8.noarch.rpm perl-Test-Script-Run.spec: I: checking-url http://www.cpan.org/authors/id/S/SU/SUNNAVY/Test-Script-Run-0.04.tar.gz (timeout 10 seconds) perl-Test-Script-Run.src: I: checking perl-Test-Script-Run.src: I: checking-url http://search.cpan.org/dist/Test-Script-Run/ (timeout 10 seconds) perl-Test-Script-Run.src: I: checking-url http://www.cpan.org/authors/id/S/SU/SUNNAVY/Test-Script-Run-0.04.tar.gz (timeout 10 seconds) perl-Test-Script-Run.noarch: I: checking perl-Test-Script-Run.noarch: I: checking-url http://search.cpan.org/dist/Test-Script-Run/ (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 0 warnings. => ok Replacing PERL_INSTALL_ROOT with DESTDIR would seem to be a good idea, given the recent fun along those lines :) Think about including %{?perl_default_filter} by default, even if just pro forma. It won't hurt anything and might save some pain down the line. I hate "too wide" wildcard in %file, so a more precise could be %{perl_vendorlib}/Test %{_mandir}/man3/Test* N.B. /usr/share/perl5/Test is already owned by perl-Test-Exception (which is required), so you don't need to own it (Guidelines says "MUST: Packages must not own files or directories already owned by other packages."), but this is F >= 13 specific. F <= 12 use /usr/lib/perl5/vendor_perl/5.10.0/Test which must be owned. Mock for EL-5 enter a infinite root. Sorry! since you don't have any existing picks, you must make a geographic selection. (1) Africa (2) Asia (3) Australasia (4) Central America (5) Europe (6) North America (7) Oceania (8) South America Select your continent (or several nearby continents) [] Probably because DEBUG util.py:255: Aucun paquet trouvé pour perl(IPC::Run3) Mock for F-13 is ok. Koji scratch buld for rawhide (perl 5.12.1) is ok http://koji.fedoraproject.org/koji/taskinfo?taskID=2291633 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review