Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: arpwatch - Network monitoring tools for tracking IP addresses on a network https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213832 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2006-11-08 18:04 EST ------- * The service related scriptlets don't follow the guidelines * the adduser followed by a chsh is a bit odd. * why isn't the useradd only done for the first install? * in %files /etc should certainly be %{sysconfdir} * just a comment, but perl one liner could be replaced by a sed, (or even a patch to be sure that it breaks if the files change in some way) * similarly the awk embedding could also be done as a patch and you'll use your scripts to regenerate the patch. * if there is a libpcap library nearby (see line 209 to 221 in configure.ac) it is used, for example in the BUILD directory. Maybe this part of the configure/configure.ac could be patched out. It shouldn't be annoying in mock, however. * maybe the oui.txt could be provided in another package and be used to regenerate ethercode.dat to have more uptodate infos. I have found http://www.mail-archive.com/debian-legal@xxxxxxxxxxxxxxxx/msg32779.html on that subject. * some Requires are missing. I think /usr/sbin/sendmail or smtpdaemon (and also maybe /usr/sbin/sendmail as BuildRequires). snmpwalk is more or less required for arpsnmp, but it is better in my opinion not to have a dependency nor do something special, the sysadm should be able to figure out. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review