Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=610211 Adel Gadllah <adel.gadllah@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adel.gadllah@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |adel.gadllah@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Adel Gadllah <adel.gadllah@xxxxxxxxx> 2010-07-02 02:45:40 EDT --- Package Review: [+] source files match upstream: 32ab9849994da70f461fc78c59a2b930d294f8c7 [+] package meets naming and versioning guidelines. [+] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] license field matches the actual license. [+] license is open source-compatible: LGPLv2+ [+] latest version is being packaged. [+] BuildRequires are proper. [+] compiler flags are appropriate. [+] package builds in koji. [+] package installs properly. [+] debuginfo package looks complete. [1] rpmlint is silent. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] scriptlets are sane. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no libtool .la droppings. ================================== [1]: Just noise: ----------- unique3-2.90.1-1.fc14.src/unique3.spec: W: no-cleaning-of-buildroot %clean unique3-2.90.1-1.fc14.src/unique3.spec: W: no-buildroot-tag unique3-2.90.1-1.fc14.src/unique3.spec: W: no-%clean-section ----------- => Approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review