Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603632 Pravin Satpute <psatpute@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #11 from Pravin Satpute <psatpute@xxxxxxxxxx> 2010-07-01 00:57:11 EDT --- 1) please drop EULA from spec file + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2285029 + rpmlint is silent for SRPM and for RPM. typemade-josefinsansstd-light-fonts.noarch: W: obsolete-not-provided josefinsansstd-light-fonts -> since obsoluted package built only in devel branch, no need for provides here typemade-josefinsansstd-light-fonts.src: W: no-buildroot-tag -> this is not require now + source files match upstream url 22f58c425e0775e5234e53ec7bf94116 typemade-JosefinSansStdLight.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application + Approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review