Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605373 --- Comment #8 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> 2010-06-30 20:05:53 EDT --- MUST Items: + rpmlint output OK (see above) + named and versioned according to the Package Naming Guidelines + spec file name matches base package name + complies with all the legal guidelines: ! License: GPLv2+ valid, but the actual license is GPLv2+ with exceptions + No known patent problems + No emulator, no firmware, no binary-only or prebuilt components + COPYING packaged as %doc ! Exception_to_GPL_for_Qt.txt must also be packaged as %doc + source matches upstream: MD5: 47710e7aa14c2a672c7f28457b0c956f SHA1: 105f353f36e9625d1eb15f1a315882f214dbe026 SHA256: bbe07eedec4bda95cca994002941b91fd0e50d5cdee2bf79be0c4f7b930cc7da + builds on at least one arch (F12 Koji scratch build) + no known non-working arches, so no ExcludeArch needed + no missing BuildRequires (builds in mock) ! translations are not properly tagged per language %{_datadir}/%{name}/i18n is not an acceptable way to package translations Please use %dir %{_datadir}/%{name}/i18n/ to own the directory and call %find_lang --with-qt to get the files lang-tagged properly. + ldconfig correctly called in %post and %postun + no duplicated system libraries + package not relocatable ! directory ownership not correct: + doesn't own directories owned by another package ! doesn't own all package-specific directories: %{_datadir}/%{name}/ not owned, please add %dir %{_datadir}/%{name}/ ! doc dir listed twice: %docdir %{_datadir}/%{name}/doc %{_datadir}/%{name}/doc Since those files are needed at runtime, please use just %{_datadir}/%{name}/doc instead. + no other duplicate files in %files + permissions correct, defattr used correctly + macros used where possible + no non-code content + no large documentation files, so no -doc package needed ! %doc files required at runtime: The %docdir marking of %{_datadir}/%{name}/doc is incorrect (see above). + all header files in -devel + no static libraries, so no -static package needed + /usr/lib(64)/*.so symlinks are correctly in -devel + /usr/lib(64)/qgis/*.so plugins (NOT symlinks) are correctly NOT in -devel + -devel requires %{name} = %{version}-%{release} + no .la files + .desktop file for the GUI app qgis present + desktop-file-install is used in %install and the .desktop file passes validation + all filenames are valid UTF-8 + other packaging guidelines: + complies with the FHS + proper changelog, tags, BuildRoot, BuildRequires, Summary ! Description errors: * In %description grass, "with GRASS system." should be "with the GRASS system." * In %description python, "Python integrations" should be "Python integration", and the dot at the end is missing. + no macros in Summary and Description + no non-UTF-8 characters + all relevant documentation included as %doc + RPM_OPT_FLAGS are used (%cmake macro) + debuginfo package is valid + no rpaths + no configuration files, so %config guideline doesn't apply + no init scripts, so init script guideline doesn't apply + no timestamp-clobbering file commands + _smp_mflags used + not a web application, so web application guideline doesn't apply + no conflicts No version-specific MUST items for F13 and F14. Version-specific MUST items for F12: + %clean section present and correct + buildroot is deleted at the beginning of %install SHOULD Items: + license already included upstream + no translations for description and summary provided by upstream + package builds in mock (F12 Koji scratch build) ! package doesn't build in Rawhide (Qt 4.7) * will do functionality test later + scriptlets are sane + subpackages other than -devel also require %{name} = %{version}-%{release} + no .pc files, so "placement of .pc files" is irrelevant + no file dependencies Please fix the following items: MUST Items: * change License to GPLv2+ with exceptions and package Exception_to_GPL_for_Qt.txt as %doc * use %dir %{_datadir}/%{name}/i18n/ and %find_lang --with-qt instead of %{_datadir}/%{name}/i18n/ * add %dir %{_datadir}/%{name}/ * remove %docdir %{_datadir}/%{name}/doc * fix "with GRASS system" to "with the GRASS system" in %description grass * fix "Python integrations" to "Python integration" in %description python * add a dot at the end of %description python SHOULD Items: * get the package to build in Rawhide (I can help if needed, at least by firing up scratch builds, and if we really can't get that to work right now and everything else works fine, we can proceed with the sponsorship process so you can at least fire up scratch builds) Obviously, the Rawhide issue should get fixed before issuing builds for releases, in order to preserve upgrade paths, and if not sorted out in a reasonable time, an FTBFS bug will get filed and you'll be asked to act on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review