Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579428 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx --- Comment #3 from Till Maas <opensource@xxxxxxxxx> 2010-06-30 10:15:56 EDT --- Some issues I found at first sight: 1) the manpage does not need to be gziped manually, this is done automatically by rpm 2) The complex License tag should have a comment explaining why it is that complicated 3) for the locales find-lang.sh should be used (see package guidelines) 4) the correct SF.net download URL is downloads.sourceforge.net/%{name}/%{name}-1.0-rc3.tar.bz2 iirc (see Source guidelines) 5) The patches need comments explaining why they are not upstreamable or if they are, what there upstream status is e.g. a pointer to the upstream tracker with the patch would be good. And please add a date to these comments If you need detailed URLs to the mentioned guidelines, please ask and I will provide them. And please provide links to unofficial reviews you performed, if you did some. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review