Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609348 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-06-30 00:42:55 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2282078 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) e11c23bf1643f78d754ee5c21bedacfbb11d161e Catalyst-Controller-ActionRole-0.14.tar.gz e11c23bf1643f78d754ee5c21bedacfbb11d161e ../SOURCES/Catalyst-Controller-ActionRole-0.14.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=14, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.65 cusr 0.08 csys = 1.77 CPU) + Package perl-Catalyst-Controller-ActionRole-0.14-1.fc14.noarch => Provides: perl(Catalyst::Controller::ActionRole) = 0.14 Requires: perl(Catalyst::Utils) perl(Class::MOP) perl(List::Util) perl(Moose) perl(Moose::Meta::Class) perl(MooseX::Types::Moose) perl(namespace::clean) perl(String::RewritePrefix) + Not a GUI application Suggestions: 1) you will resolve dependencies automatically so no need of following in spec Requires: perl(Catalyst::Runtime) >= 5.71001 Requires: perl(Class::MOP) >= 0.80 Requires: perl(Moose) >= 0.90 Requires: perl(String::RewritePrefix) >= 0.004 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review