Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571993 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oget.fedora@xxxxxxxxx --- Comment #7 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-06-28 00:16:01 EDT --- Hi, I'll review this package but there are two important issues that need to be fixed first: 1- The build needs to be verbose. We want to see what flags are passed to the compiler. Currently the compiler invocations are silent because of the lines that start with @ in the Makefile. We need to patch or sed these out. I am also not sure whether removing the whole "ifeq ($(USE_DEBUG),yes)" part from the Makefile is right. This also removes -DNDEBUG, and other flags which might be needed by the source, which I didn't check. Simply appending the optflags at the end should be sufficient. Something like sed -i 's|DNDEBUG|DNDEBUG $(CXXFLAGS)|' Makefile Let me know if I am missing something. 2- Since this is a desktop application, we need a .desktop file, an icon and the scriptlets, as usual. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review