Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608206 --- Comment #3 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-06-27 06:18:38 EDT --- Jussi, thanks for the review. (In reply to comment #1) > Some suggests: > 1.License: (GPLv2 or GPLv3) and GPLv2+ and LGPLv2+ > -> GPLv3 > Because license field only applies to binary rpm It's in summary GPLv3, yes, but I refer to: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios If there are some files under a different license, it must stated in the spec, and refering to the COPYING file is one possibiliy. e.g. wide_arith.h is licensed under LGPLv2+, so this needs to be reflected somewhere. > 2. > It'll be better to delete .a files instead of shipping it in -static > subpackage. > > From packaging guideline: > Static libraries should only be included in exceptional circumstances Yes, I usually delete them, but because this is a dependency of flint, which shipps static libs, I choosed to ship them here too. (Furthermore, I don't know yet, if sagemath needs static libs, if it doesn't maybe we can delete them later on.) > 3. > > You can add a make test to %check I think, I already did... :) ########################################################################### (In reply to comment #2) > rpmlint output: [snip] > > - You can fix the configure-without-libdir warning by replacing > ./configure --cflags="%{optflags} -fPIC" --prefix=%{_prefix} \ > --gmp-prefix=%{_prefix} \ > --ntl-prefix=%{_prefix} \ > --flint-prefix=%{_prefix} > with > python makemakefile.py \ > --cflags="%{optflags} -fPIC" --prefix=%{_prefix} \ > --gmp-prefix=%{_prefix} --ntl-prefix=%{_prefix} \ > --flint-prefix=%{_prefix} > makefile Done. > - Fix the no-ldconfig-symlink either by patching makemakefile.py so that > libzn_poly.so becomes a symlink, or by replacing the installed duplicate with a > symlink at the end of %install. Done in %install. [snip] > MUST: Optflags are used and time stamps preserved. NEEDSWORK > - Preserve time stamps in %install by adding -p (or -a) to the cp argument. Done. > MUST: A package must own all directories that it creates or require the package > that owns the directory. OK > - I recommend using a trailing / for directories in %files to make it clearer, > i.e. > %{_includedir}/zn_poly/ Changed. > MUST: All relevant items are included in %doc. Items in %doc do not affect > runtime of application. NEEDSWORK > - Don't include README, it only contains instructions for compilation, which > aren't relevant to the binary rpm. > - Maybe include doc/REFERENCES ? ok, done. > MUST: Static libraries must be in a -static package. OK > - There's nothing wrong with shipping static libraries (in -static), but > normally it isn't done in Fedora. > - If you want, you can just not ship the static library by either not > installing it in %install, or by deleting it at the end of %install. flint has static libs, so I have to ship them too, or the libs from flint would be nonsense. (Maybe if sage doesn't require the static libs, we'll delete it.) ########################################################################### Spec URL: http://tomspur.fedorapeople.org/review/zn_poly.spec SRPM URL: http://tomspur.fedorapeople.org/review/zn_poly-0.9-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review