Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=608206 Chen Lei <supercyper1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper1@xxxxxxxxx --- Comment #1 from Chen Lei <supercyper1@xxxxxxxxx> 2010-06-25 23:36:21 EDT --- Some suggests: 1.License: (GPLv2 or GPLv3) and GPLv2+ and LGPLv2+ -> GPLv3 Because license field only applies to binary rpm 2. It'll be better to delete .a files instead of shipping it in -static subpackage. >From packaging guideline: Static libraries should only be included in exceptional circumstances 3. You can add a make test to %check -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review