Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604438 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-25 14:27:07 EDT --- Some notes: * %define -> %global - Now we prefer to use %global rather than %define https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * ruby(abi) dependency - Writing ruby(abi) dependency is a must https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * Explcitly defined macros - Explicitly defined %ruby_sitelib is used nowhere. - Please use explicitly defined %geminstdir also in %files * Explicit version dependency - As rubygem-templater in Fedora on all supported branches have higher version than 0.5.0, the explicit ">= 0.5.0" part is not needed, ref: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * BuildRoot tag - BuildRoot tag is no longer used so you can remove this (although rpmlint may complain) on Fedora (not on EPEL) https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag ! %changelog - Please also write your name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review