Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605610 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-25 13:07:30 EDT --- For 0.2.3-1 * (Build)Requires - Build fails without additional "BR: rubygem(rake), rubygem(hoe)" - On the other hand, while installed gemspec file says rubygem(hoe) is needed for Requires, however as far as I checked the codes, hoe is needed in Rakefile and hoe does not seem to be needed on runtime. I think hoe dependency can be removed from installed gemspec and "R: rubygem(hoe)" can be removed. * Test related issue - Would you check if the (ignored) test failure and warnings can really be ignored? - Especially I think that it is better that you fix the warning of "warning: instance variable @foo not initialized". - Well, it may be more readable and preferable to create a patch rather than to specify the lines to be deleted by sed, however not a blocker. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review