Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603634 --- Comment #7 from Chen Lei <supercyper1@xxxxxxxxx> 2010-06-25 03:12:03 EDT --- (In reply to comment #6) > (In reply to comment #5) > > Some suggestions: > > 1.Group: Development/Languages->Group: Development/Libraries > > > > Development/Languages is for python runtime only. > May I know where its documented? I think we can find many python-* packages in > Fedora using Development/Languages Long ago, I see rpm group definitions from an opensuse document, I can confirm Development/Languages is for python/perl/ruby/lisp runtime only and not appropriate for python modules. But I'm not sure if Development/Libraries is right for python modules, but a lot of python modules in fedora already use Development/Libraries as their group name. See http://en.opensuse.org/Packaging/SUSE_Package_Conventions/RPM_Groups#2.2._Development > > 2. > > It'll be better add %check to the spec after %install, then del robofab/test > > > > %check > > PYTHONPATH=%{buildroot}%{python_sitelib} python RoboFab/robofab/test/runAll.py > > > Is this MUST by guidelines. %check section is not mandatory in fedora packaging guideline yet it depends on packages/maintainers, but it'll be better to add %check in spec file if possible. Maybe the test can pass if we change the command to: PYTHONPATH=RoboFab python RoboFab/robofab/test/runAll.py -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review