Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607342 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2010-06-25 01:30:17 EDT --- Yep, that builds fine for me. rpmlint just says: python-markupsafe.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/markupsafe/_speedups.so _speedups.so() (64bit) which as far as I know you can't do anything about because we have no dependency filtering for arch-specific packages. The only issue I see: perhaps I'm missing something, but does the URL actually have anything at all to do with this package? I can't find any mention at all of this module at http://dev.pocoo.org/. It's what pypi says, so I'm no going to fret over it, but it seems a bit odd. Honestly I'd probably list the pypi page here instead because it at least has useful information related to the module. * source files match upstream. sha256sum: d2a1980ea5bae80a999dad6aafe1ad2f0440522630caeecb84ffe061c8054342 MarkupSafe-0.9.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: python3-markupsafe-0.9.2-3.fc14.x86_64.rpm _speedups.so()(64bit) python3-markupsafe = 0.9.2-3.fc14 python3-markupsafe(x86-64) = 0.9.2-3.fc14 = libpython3.1.so.1.0()(64bit) python(abi) = 3.1 python-markupsafe-0.9.2-3.fc14.x86_64.rpm _speedups.so()(64bit) python-markupsafe = 0.9.2-3.fc14 python-markupsafe(x86-64) = 0.9.2-3.fc14 = libpython2.6.so.1.0()(64bit) python(abi) = 2.6 * %check is present and all tests pass: Ran 2 tests in 0.270s Ran 2 tests in 0.253s * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review