Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606379 --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-24 15:06:11 EDT --- (In reply to comment #3) > add "-V" option to the "gem install" command > > I am sorry, but I was not able to make the build better. - Here adding "-V" option is just to make build log more verbose so that we can check what is actually done (especially if optflags are correctly honored or not) > The debug package has still no sources included: > > $ rpmlint ~/rubygem-oniguruma-debuginfo-1.1.0-2.fc13.x86_64.rpm > rubygem-oniguruma-debuginfo.x86_64: E: debuginfo-without-sources > 1 packages and 0 specfiles checked; 1 errors, 0 warnings. - With rebuilt on koji, debuginfo rpm is correctly generated. Please check if you have surely redhat-rpm-config installed. > The patch includes the path so I is easier to add other commands (No "cd" is > needed jet). This can changed back later. - See below. For -2: * Unneeded || : - Please avoid to use "|| :" unless really unavoidable ( In this case, if "make all" fails rpmbuild must stop there and "|| :" should really be removed ) * Patch0 - Making patch header contain such large paths should be avoided ( current patch cannot be used with the version is to be upgraded ) Containing "oniguruma-1.1.0/Rakefile" is enough for header. * Macros in comment ------------------------------------------------------------ rubygem-oniguruma.src:50: W: macro-in-comment %{optflags} rubygem-oniguruma.src:54: W: macro-in-comment %{geminstdir} ------------------------------------------------------------ - It is preferable that you always excape macros in comment with using %% because (while for this case there are no problems) macros are expanded even in comments which sometimes causes some unexpected errors. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review