Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607342 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2010-06-24 01:06:01 EDT --- A couple of quick comments; I'll do a full review once the package builds. The spec looks as clean as can be for something that supports python 2 and 3 as well as F12 and EPEL. However, some additional conditionals are needed for the first two lines as python3 isn't available on F12 or EPEL and F13 doesn't need the python_site* define. (F13 also doesn't need %clean, the BuildRoot line or the buildroot cleaning in %install, but it's pointless to conditionalize those.) So: %if 0%{?fedora} > 12 || 0%{?rhel} > 6 %global with_python3 1 %else %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print (get_python_lib())")} %endif (probably horribly wordwrapped) and things are good. Also, I suspect this will have problems on F12 anyway as its arch-specific so you probably want the python_sitearch define there instead of sitelib, especially since sitearch is used in %files. Unfortunately this fails to build for me in rawhide; setyp.py won't run because setuptools is not installed. A scratch build is at http://koji.fedoraproject.org/koji/taskinfo?taskID=2269296 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review