Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606759 Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(mcepl@xxxxxxxxxx) | --- Comment #2 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-06-23 15:36:52 EDT --- Using the stand-alone spec, as it uses better filesystem macros #+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n) * TODO Review [70%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** DONE source files match upstream 88d1e23115ee9f2961186b62e55f5704 nvi-1.81.6.tar.bz2 88d1e23115ee9f2961186b62e55f5704 /home/michel/rpmbuild/SOURCES/nvi-1.81.6.tar.bz2 ** DONE License [3/3] *** DONE License is Fedora-approved *** DONE License field accurate *** DONE License included iff packaged by upstream ** TODO rpmlint [0/2] *** FAIL on src.rpm - State "FAIL" from "" [2010-06-23 Wed 21:04] \\ nvi.src:81: W: macro-in-comment %patch27 (when commenting out, I normally just replace % with # to avoid this) nvi.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 4) (if using Emacs, C-x h M-x untabify would fix this) nvi.src: W: patch-not-applied Patch27: nvi-28-regex_widechar.patch *** FAIL on x86_64.rpm - State "FAIL" from "TODO" [2010-06-23 Wed 21:30] \\ nvi.x86_64: E: non-standard-executable-perm /usr/share/nvi/recover 0555L ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** N/A Use %find_lang to handle locale files ** DONE Build [3/3] *** DONE Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=2268677 *** DONE BRs complete *** DONE Directory ownership ** TODO Spec inspection [8/9] *** DONE No duplicate files *** FAIL File permissions - State "FAIL" from "TODO" [2010-06-23 Wed 21:32] \\ See rpmlint result *** DONE Filenames must be UTF-8 *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install *** DONE Macro usage consistent *** DONE Documentation [2/2] **** N/A If large docs, separate -doc **** DONE %doc files are non-essential -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review