Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600467 --- Comment #12 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-06-23 12:04:49 EDT --- (In reply to comment #11) > Thank you very much for reviewing this package! I am really excited about > hopefully getting this package into Fedora. Hi Chris, I'm not a sponsor, so I can't formally review this package. Nonetheless, polishing the spec file will certainly help to find one. In addition, you usually need to offer some more packages and comment on other packager's review requests to show that you're familiar with the packaging guidelines. Here are a couple of further remarks on your package: - In Source0, replace JAGS-2.1.0.tar.gz with JAGS-%{version}.tar.gz or %{name}-%{version}.tar.gz. It simplifies future updates of the package - I think, you can also add %{_smp_mflags} to "make docs". It enables parallel builds if possible, and thus speeds up the build process on multi-processor systems. - remove the trailing slash from %{_bindir}/jags/ because jags is not a directory here but a binary file - you can drop jags_installation_manual.pdf as it's not of much use in a binary package - also adapt the %defattr parameters of the devel package as mentioned in comment #10 - The tarball contains a copy of libltdl which should be removed in favor of the package provided by Fedora (libtool-ltdl-devel). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review