Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607081 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-06-23 06:34:28 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2266895 + rpmlint output for SRPM and for RPM. perl-Data-Taxi.noarch: W: spelling-error Summary(en_US) ish -> is, sh, dish perl-Data-Taxi.noarch: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized perl-Data-Taxi.src: W: spelling-error Summary(en_US) ish -> is, sh, dish perl-Data-Taxi.src: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized 2 packages and 0 specfiles checked; 0 errors, 4 warnings. + source files match upstream url (sha1sum) e7bed3a84a844d669219fd77d74ba44cbb562943 Data-Taxi-0.95.tar.gz e7bed3a84a844d669219fd77d74ba44cbb562943 Data-Taxi-0.95.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave ok 1 + Package perl-Data-Taxi-0.95-1.fc14.noarch=> Provides: perl(Data::Taxi) = 0.95 Requires: perl >= 0:5.006 perl(Carp) perl(constant) perl(Exporter) perl(strict) perl(vars) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application Suggestions: 1) I think Changelog should include email id of packager also. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review