Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=607079 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-06-23 06:28:06 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2266873 + rpmlint output for SRPM and for RPM. 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + source files match upstream url (sha1sum) 20cabe0c333b146e6efce14fe92bfd15ec96ed3d Template-Plugin-Cycle-1.06.tar.gz 20cabe0c333b146e6efce14fe92bfd15ec96ed3d Template-Plugin-Cycle-1.06.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=78, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.15 cusr 0.01 csys = 0.20 CPU) + Package perl-Template-Plugin-Cycle-1.06-1.fc14.noarch=> Provides: perl(Template::Plugin::Cycle) = 1.06 Requires: perl >= 0:5.005 perl(overload) perl(Params::Util) perl(strict) perl(Template::Plugin) perl(vars) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application Suggestions: 1) looks yum already take care Requires: perl(Params::Util) >= 0.20 Requires: perl(Template) >= 2.10 so you can drop it. 2) I think Changelog should include packager email id also. 3) following BR is redundant in spec BuildRequires: perl >= 0:5.005 4) license from LICENSE file looks "GPLv2+ or Artistic" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review