Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=600467 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #9 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-06-23 06:13:52 EDT --- Hi Chris, .la files must not be packaged in Fedora according to the packaging guidelines. I suggest to remove them in the %install section after "make install", e.g. with find %{buildroot}%{_libdir} -name "*.la" -exec rm -f {} \; Also, drop them in the %files section. Here are some further comments: - in the devel package, use a fully versioned dependency: Requires: %{name} = %{version}-%{release} (rather than Requires: JAGS = %{version}) - According to the source file headers, the license is GPLv2+ because of the addition "or (at your option) any later version". - add file COPYING to the base package (as %doc) - the Group of the devel package should be 'Development/Libraries' - as a minor cosmetic addition, I suggest to append a slash to directory names, e.g. %{_includedir}/JAGS/ This way it's easier to recognize that a folder is added rather than a single file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review