Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606666 ELMORABITY Mohamed <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pikachu.2014@xxxxxxxxx --- Comment #2 from ELMORABITY Mohamed <pikachu.2014@xxxxxxxxx> 2010-06-22 22:21:14 EDT --- Hi, some comments before a potential review: - libX11-devel at least is missing as a BuildRequires - sselp is not compiled using the Fedora standard flags. CFLAGS must be set to %{optflags}. To fix it, you can add this line in your %prep section: sed -i "s/CFLAGS = .*/CFLAGS = %{optflags} \${INCS} \${CPPFLAGS}/" config.mk - your patch can be dropped if you call "make install" like this in your %install section: make install DESTDIR=%{buildroot} PREFIX=%{_prefix} - no debuginfos are generated, because of the "-s" option set in LDFLAGS (see config.mk). To fix it, add also this line in %prep: sed -i "/LDFLAGS/ s/-s//" config.mk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review