Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 ELMORABITY Mohamed <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pikachu.2014@xxxxxxxxx --- Comment #64 from ELMORABITY Mohamed <pikachu.2014@xxxxxxxxx> 2010-06-22 12:30:33 EDT --- (In reply to comment #62) > Just for curiosity, do you know why the JAR installed (6 MB) is 150% bigger > than the one generated by the authors (4 MB)? Because this package is not valid, accorded to the guidelines. It embeds dependencies, whereas it is forbidden: https://fedoraproject.org/wiki/Packaging/Java#Pre-built_JAR_files_.2F_Other_bundled_software Upstream voluntarily embeds metadata-extractor.jar (see build.xml). This should not be the case. Moreover, I don't understand why you also embed commons-codec.jar and ant.jar with your patch josm-0-bzip2.patch. Please don't embed dependencies, you'd better modify your wrapper to set these dependencies in the classpath. By the way, is commons-codec really required? If ant is called in the code, I can't find any call to commons-codec. So: 1) remove the patch josm-0-bzip2.patch 2) try to remove (with a patch for example) the following line in build.xml: <zipfileset src="lib/metadata-extractor-2.3.1-nosun.jar" /> 3) replace your wrapper script with the one attached in this review (josm.wrapper) 4) add ant and metadata-extractor as Requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review