Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578024 --- Comment #24 from Chen Lei <supercyper1@xxxxxxxxx> 2010-06-21 13:51:33 EDT --- Some suggestions: 1.Do not use -f in %file, list all them explicitly 2.Scriptlet should be more clear. See http://fedoraproject.org/wiki/Packaging:ScriptletSnippets Some scriprlet should be moved to initscript Please refer mysql SRPM 3. %defattr(-,ingres,ingres,-) -> %defattr(-,root,root,-) 4. Please add a blank file between changelog entities and before %file [subpackagename]. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review