Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606379 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-06-21 12:26:38 EDT --- Some notes: * Optflags - Fedora specific compilation flags are not honored correctly as debuginfo rpm is not generated correctly. * build.log does not show this clearly: --------------------------------------------------------------- 43 + gem install --local --install-dir /builddir/build/BUILD/rubygem-oniguruma-1.1.0//usr/lib/ruby/gems/1.8 --force --rdoc /builddir/build/SOURCES/oniguruma-1.1.0.gem 44 No definition for oregexp_initialize 45 No definition for oregexp_initialize 46 Building native extensions. This could take a while... --------------------------------------------------------------- Add "-V" option to "gem install" to make build.log more verbose. * The reason Fedora specific compilation flags are not correctly honored is that ext/extconf.rb overrides CFLAGS value: --------------------------------------------------------------- 3 $CFLAGS='-Wall' --------------------------------------------------------------- Unfortunately in such cases export CONFIGURE_ARGS="--with-cflags='%{optflags}'" or so before "gem install" does not work. In the case like this, you have to recompile C extension module by yourself like ---------------------------------------------------------------- pushd ./%{geminstdir}/ext make clean all install CFLAGS="%{optflags}" ---------------------------------------------------------------- * %check ---------------------------------------------------------------- rake test | : ---------------------------------------------------------------- - "|" is pipe, not || operator - and please check if || : is really needed. * %doc in -doc - Again I think %doc attribute in -doc subpackage is redundant. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review