Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=595637 --- Comment #3 from Chen Lei <supercyper1@xxxxxxxxx> 2010-06-20 22:46:49 EDT --- (In reply to comment #1) > > A few comments for now: > - Is there a reason why you use %{?isa}? I don't think leaving them out will > cause problems, but maybe I'm wrong...? > This makes only sense, when using e.g: > %ifarch %ix86 > Requires: %{name}.(i?86|athlon|geode) > %endif > %ifarch x86_64 amd64 ia32e > Requires: %{name}.(x86_64|amd64|ia32e) > %endif > > Or is this common in KDE? > (This is my first look at a KDE/qt package ever^^) It's common in KDE packages, it's useless under most circumstance, but I still suggest to use it when requires multiarch libs explicitly. See https://fedoraproject.org/wiki/PackagingDrafts/ArchSpecificRequires > > - You aren't consistend with tabbing: > 4 Name: qoauth > 5 Version: 1.0.1 > 6 Release: 0.1.%{gitdate}git%{githash}%{?dist} > 7 Summary: Qt-based C++ library for OAuth authorization scheme > 8 Group: System Environment/Libraries > 9 License: LGPLv2+ > 10 URL: http://github.com/ayoy/qoauth > > Would be more readable otherwise. > My Editor is wrong some days ago: ), will be fixed soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review