Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567877 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx Blocks| |182235(FE-Legal) AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-06-20 11:45:41 EDT --- Review: Good: - group ok - name ok (this is also a python module, but will mainly used from commandline) - libs correctly packaged - no *.la Needswork: - https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define better use the new python defines from https://fedoraproject.org/wiki/Packaging:Python#Macros - Summary might be too long to display everywhere. How about "VNC recording tool that saves session as FLV" ? - Why so much R? xorg-x11-utils alsa-utils and gawk should be added automatically, when the *.so requires it. So it seems, it doesn't. (Couldn't find something about this in a *.py file, can you give me a pointer?) - %doc also needs to contain README.rst - add a %check section e.g.: %check PYTHONPATH=%{buildroot}%{python_sitearch} python flvscreen/test.py - %files contains hardcoded python version and version of this package There will be likely a python 2.7, so this will fails building, please change it to e.g.: %{python_sitearch}/vnc2flv-%{version}-py?.?.egg-info ############################################################################## ############################ blocking FE-LEGAL ############################### - I'm unsure about the license. A comment from vnc2flv/d3des.py: # This is a Python rewrite of d3des.c by Richard Outerbridge. # # I referred to the original VNC viewer code for the changes that # is necessary to maintain the exact behavior of the VNC protocol. # Two constants and two functions were added to the original d3des # code. These added parts were written in Python and marked # below. I believe that the added parts do not make this program # a "derivative work" of the VNC viewer (which is GPL'ed and # written in C), but if there's any problem, let me know. # # Yusuke Shinyama (yusuke at cs dot nyu dot edu) # D3DES (V5.09) - # # A portable, public domain, version of the Data Encryption Standard. # # Written with Symantec's THINK (Lightspeed) C by Richard Outerbridge. # Thanks to: Dan Hoey for his excellent Initial and Inverse permutation # code; Jim Gillogly & Phil Karn for the DES key schedule code; Dennis # Ferguson, Eric Young and Dana How for comparing notes; and Ray Lau, # for humouring me on. # # Copyright (c) 1988,1989,1990,1991,1992 by Richard Outerbridge. # (GEnie : OUTER; CIS : [71755,204]) Graven Imagery, 1992. # -> "two functions were *ADDED* to the *ORIGINAL* d3des code" etc So I'd say this also needs to be GPL'ed like d3des and not MIT spot, what do you think? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review