Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=521707 Kalev Lember <kalev@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalev@xxxxxxxxxxxx Flag|needinfo? |fedora-review? --- Comment #6 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-06-19 19:29:12 EDT --- Taking for review. I think "fixing" the spec to use %{__rm} doesn't add anything useful and if you wish you should just revert back to using plain rm. There was a recent discussion about the %__ macros in fedora-devel list and the consensus was that they are useless. Are the .txt files in site-packages/zc/buildout/ and site-packages/zc.buildout-1.4.1-py2.6.egg-info/ needed? Perhaps they'd be more useful in the standard docdir? You could do something like this at the end of %install to move them to docdir: mkdir _docdir find $RPM_BUILD_ROOT%{python_sitelib}/ -name "*.txt" -exec echo mv {} _docdir/ \; and then later: %files %doc _docdir/* > # Remove CFLAGS=... for noarch packages (unneeded) > CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build You can remove CFLAGS= as you commented yourself. Current python guidelines [1] suggest to wrap the sitelib definition in an %if, as it's not needed in F13 and up. But this is just nitpicking and no real need to change it. %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif [1] https://fedoraproject.org/wiki/Packaging:Python -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review