Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603514 Chen Lei <supercyper1@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |supercyper1@xxxxxxxxx --- Comment #10 from Chen Lei <supercyper1@xxxxxxxxx> 2010-06-19 15:15:32 EDT --- Some suggestions: %{_datadir}/cmake/Modules is not owned by this package, you may need to remove Findlibmodman.cmake if compiling libproxy 0.4.4 don't need this files or requires cmake. Requires: pkgconfig is also not needed now, rpmbuild will take it automatically. (In reply to comment #7) > [FAILED] license text included in package. > I didn't catch this in my earlier iteration, sorry. -devel needs the %docs. This is probably not needed, %file don't need to not include the same files twice. Most libraries(glibc zlib qt etc.) in fedora don't include the same doc with -devel subpackage, rpmlint warnings can be ignored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review