Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=605853 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-06-19 08:21:31 EDT --- Review: Good: - name ok - %build ok - %install ok - macros everywhere - no libs/*.la - license ok (according to the headers, so COPYING file, see needswork) - noarch ok - rpmlint ok $ rpmlint ./python-snpp-1.1.2-1.fc13.src.rpm noarch/python-snpp-1.1.2-1.fc13.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - sources match upstream: bab9732f7ddf3af54fb5262b6dae35da Needswork: - missing BR python-setuptools - query upstream to include a proper COPYING file with the license - summary unnecessary to long: "Simple Network Paging Protocol" would be enought, the rest is in description anyway - group wrong: You say this are 'libraries' -> Development/Libraries? - It would be better, if you could write in %files: %{python_sitelib}/Pager.py* %{python_sitelib}/snpplib.py* %{python_sitelib}/python_snpp*.egg-info So you know, when building the egg fails (e.g. I still wonder, why there is a already an egg-info in the archive...) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review