[Bug 605784] Review Request: googlecl - Command line tools for the Google Data APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605784

--- Comment #3 from Chen Lei <supercyper1@xxxxxxxxx> 2010-06-19 00:39:28 EDT ---
1.rpmlint googlecl-0.9.5-2.fc14.src.rpm 
googlecl.src: W: no-cleaning-of-buildroot %install
googlecl.src: W: no-cleaning-of-buildroot %clean
googlecl.src: W: no-buildroot-tag
googlecl.src: W: no-%clean-section

%clean section is still needed for F12


2.You still need those macros for building rpm in F12:

%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif
3. you can add changlog to %doc

Except those trival issue, the package is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]