Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603514 --- Comment #7 from Ian Weller <ian@xxxxxxxxxxxxx> 2010-06-18 20:53:49 EDT --- [FAILED] license text included in package. I didn't catch this in my earlier iteration, sorry. -devel needs the %docs. [ OK ] BuildRequires are proper. [ OK ] package builds in mock. [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [FAILED] rpmlint is silent. libmodman-devel.x86_64: W: no-documentation [ OK ] final provides and requires are sane [ OK ] %check is present and all tests pass [ OK ] no shared libraries are added to the linker search paths w/o ldconfig [ OK ] owns the directories it creates. [FAILED] doesn't own any directories it shouldn't. -devel needs to own %{_includedir}/%{name} just list the directory (without %dir) and it'll pull everything under it in [ OK ] no headers outside -devel [ OK ] no pkgconfig files outside -devel [ OK ] no libtool .la droppings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review