Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542767 --- Comment #4 from Christian Krause <chkr@xxxxxxxxxxx> 2010-06-18 15:12:01 EDT --- Sorry for the delay... I was waiting to see libghemical in koji and since it didn't appear ghemical dropped a little bit in my priorities - sorry... ;-) Here is now the full review. In general there are no major issue, just some minor and easy to fix pieces (marked as TODO). Please build libghemical officially in koji first so that the final test can be done with a koji build of ghemical as well. * naming: OK * spec file name: OK * sources: OK - matches upstream: 30f29b21d2f0649fc79823a7042131b5 ghemical-2.99.2.tar.gz - spectool -g works * license: OK - actual license matches License field - GPLv2+ acceptable - License file packaged * rpmlint: TODO rpmlint RPMS/i686/ghemical-* SRPMS/ghemical-2.99.2-10.fc13.src.rpm SPECS/ghemical.spec ghemical.i686: W: spelling-error %description -l en_US initio -> initial, initiation, initiate ghemical.i686: W: file-not-utf8 /usr/share/doc/ghemical-2.99.2/AUTHORS ghemical.i686: W: no-manual-page-for-binary ghemical ghemical.src: W: spelling-error %description -l en_US initio -> initial, initiation, initiate 3 packages and 1 specfiles checked; 0 errors, 4 warnings. - file-not-utf8: should be fixed, e.g. by using something like this: # fix encoding iconv -f iso8859-1 -t utf-8 AUTHORS > AUTHORS.conv && \ touch -r AUTHORS AUTHORS.conv && \ mv -f AUTHORS.conv AUTHORS - the remaining warnings are false positives * legible & American English: OK * compilation: TODO - if there is no need, don't run aclocal and auto* tools - don't explicitly override LIBS or CXXFLAGS unless there is a good reason - for ghemical, it should be sufficient to use %configure --enable-threads --enable-openbabel make %{?_smp_mflags} in the build section - package builds locally - build in koji not possible because libghemical was not built yet * BuildRequires: TODO - at least libtool, flex and gcc-gfortran are not required * Requires: TODO - should require hicolor-icon-theme (for the ownership of the directories /usr/share/icons/hicolor/*/apps/ ) * locale handling: OK * directory ownership: OK * files not listed twice: OK * permissions: OK, %defattr used * clean section: OK * macros consistently used: OK * code vs. content: OK (besides some examples no content) * large documentation in -doc subpackage: OK - the documentation is about 1MB, so IMHO it would be nicer to split it off into an additional documentation package - however, since it is "only" 1MB it won't block the review * *.la files, pkgconfig, static libs, headers, shared libs: OK (n/a) * .desktop file: OK - desktop file exists and works - correctly installed via desktop-file-install or desktop-file-validate * rm -rf in %install: OK * scriptlets: OK - gtk-update-icon-cache called correctly * filenames UTF8: OK * functional test: OK - basic functions work, examples can be loaded without any problems -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review